Fix UnboundLocalError in _catch_test_status when ThreadPool creation... - #6342

No actionable comments were generated in the recent review. 🎉

Walkthrough

_catch_test_status now initializes the multiprocessing pool reference to None before pool creation. Cleanup now terminates the pool only when creation succeeded. This prevents cleanup errors when pool initialization fails.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 1343a

This is a small, localized fix for an exception-handling bug, and no actionable merge-blocking risk remains beyond normal checks and review.

• Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands.}

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.61%. Comparing base (ba0306c) to head (f5c128a).
⚠️ Report is 142 commits behind head on master.

@@            Coverage Diff             @@
##           master    #6342      +/-   ##
==========================================
- Coverage   73.66%   70.61%   -3.05%     
==========================================
  Files         206      207       +1     
  Lines       22635    23639    +1004     
==========================================
+ Hits        16673    16692      +19     
- Misses       5962     6947     +985     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Hi @Poppy-mt, I think I can propose a fix for your failing CI variants in #6343. Once it gets merged I will ask you to rebase to the main branch and push again if possible so we can restore the coverage for your PR.

Ok, merged. Could you please rebase on the master branch and push again?

Ok, merged. Could you please rebase on the master branch and push again?

Hi @pevogam, thanks for merging #6343. I have rebased this PR on the latest master and pushed again.

The previous podman-related CI failures look resolved, but a new error showed up during "Installing Avocado in develop mode" (python3 setup.py develop --user):
error: Could not find suitable distribution for Requirement.parse('idna<4,>=2.5')

This happens before the tests run, while optional plugins are being installed. This PR only changes avocado/core/test.py (initialize pool to None so a ThreadPool setup failure is not masked by UnboundLocalError), so this looks like another environment/dependency issue rather than something introduced by this change.

Could you take a look, or should I just re-run the failed jobs? Thanks.

Hmmm, I wonder if GitHub's severe outage yesterday could have caused some problems in the cache. The tests passed just fine right after yesterday's merge as well.

Thanks for re-running the jobs. They failed again with the same error.

So it does not look like a one-off cache issue from yesterday's outage. Please let me know if I should wait for a CI-side fix, or if there is anything I should change on this PR. Thanks.

@PraveenPenguin Do you happen to understand what this avocado cache that fails in the CI is about? It also fails for other PRs too.

Hmmm, I reran the GH Actions workflow from the master branch and all tests pass there. Then reran here too and everything passed. It must have been Github related cache issue.